Remove redundant hardcoded code to tile corner rendering #701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #700.
This restriction exists for both
GrassTile
andSandTile
.Related investigation to the effect is done previously:
Source: #700 (comment)
This part of code has existed already before the last big update to the resource pack system. It was probably aiming to resolve the issue that a missing of corner might cause rendering misfunctioning. In the past, it actually functioned as like having
checkCorners == false
, by referring to 34c4381. What I can see is that, that method overwrite is kind of pointless as the constructions of bothSandTile
andGrassTile
already madecheckCorners = false
. However, after deeper investigation, the method overwrite had been implemented beforecheckCorners
(as you can see in 8881490). It is possibly because the developers had not realized the overshadowed functionality of code when addingcheckCorners
. Anyway, this redundant part of code which is as well limiting the customizability of resources is eventually removed here.