Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that LockableUser and User have a has_one to an mfa_config #102

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

wwahammy
Copy link
Collaborator

@wwahammy wwahammy commented Jun 11, 2024

This helps verify that adding devise :authy_authenticable to a model, like User or LockableUser, actually adds the proper associations. In particular, a has_one to mfa_config.

@wwahammy wwahammy linked an issue Jun 11, 2024 that may be closed by this pull request
@wwahammy wwahammy enabled auto-merge June 11, 2024 01:22
@wwahammy wwahammy requested review from BintLopez and camckin10 June 11, 2024 01:23
@wwahammy wwahammy disabled auto-merge June 11, 2024 01:23
@wwahammy wwahammy enabled auto-merge June 11, 2024 16:49
@camckin10
Copy link
Contributor

@wwahammy Can you please update the PR description to explain why this change is necessary?

@wwahammy
Copy link
Collaborator Author

@wwahammy Can you please update the PR description to explain why this change is necessary?

Done.

Copy link
Contributor

@camckin10 camckin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wwahammy wwahammy merged commit a8332d7 into main Jun 11, 2024
16 checks passed
@wwahammy wwahammy deleted the 84-verify-that-user-model-spec-belongs-to-mfaconfig branch June 11, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify that User model spec belongs to MfaConfig
2 participants