deps: ethereumjs-util 7 #11930
Closed
deps: ethereumjs-util 7 #11930
+12
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
7 tasks
- use version from npm, not github
legobeat
force-pushed
the
deps-ethereumjs-utils-7
branch
from
70084c8
to
5afd1f3
Compare
legobeat
commented
Oct 21, 2024
| @@ -466,7 +465,7 @@ export default async function migrate(stateAsync: unknown) { | |||
| if (Array.isArray(transactionControllerState.transactions)) { | |||
| transactionControllerState.transactions.forEach( | |||
| (transaction: TransactionParams, index: number) => { | |||
| if (transaction && !isHexString(transaction.chainId)) { | |||
| if (transaction && !transaction.chainId || (transaction.chainId && !isHexString(transaction.chainId))) { | |||
There was a problem hiding this comment.
This does not change the resulting logic and is just validating transaction.chainId to account for that isHexString does not accept arbitrary input.
I am not sure if it is correct and intended that this should evaluate to true when transaction.chainId is undefined (or otherwise not sane to pass to toHex), or if explicit handling for that should actually be added.
|
Superseded by #11932 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump deprecated dependencies to (still deprecated but) lated versions with various fixes and improvements:
ethereumjs-utilfrom6.1.0to^7.1.5ethereumjs-abifrom0.6.6to^0.6.8Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist