Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve secp256k1 package #11929

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Resolve secp256k1 package #11929

wants to merge 3 commits into from
+22 −15

Conversation

NicholasEllul
Copy link
Contributor

Description

This pull request resolves the secp256k1 to the latest version as a precaution.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NicholasEllul NicholasEllul requested review from a team as code owners October 21, 2024 21:43
@NicholasEllul NicholasEllul added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 11fed44
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/36d411ed-5704-4937-b1d1-3f7c13b3559f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@socket-security Socket Security
Copy link

socket-security bot commented Oct 21, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 380 kB nicknaso

🚮 Removed packages: npm/[email protected]

View full report↗︎

@legobeat legobeat changed the title Resolve secp256k1 package fix: Resolve secp256k1 package Oct 21, 2024
legobeat
legobeat requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/MetaMask/metamask-mobile/actions/runs/11449136476/job/31854080852?pr=11929

@NicholasEllul NicholasEllul added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8aba730
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/72f80d75-f324-445e-8f69-0094872e4bb8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini
tommasini previously approved these changes Oct 21, 2024
View reviewed changes
legobeat
legobeat reviewed Oct 21, 2024
View reviewed changes
package.json
@@ -129,7 +129,9 @@
"react-native/ws": "^6.2.3",
"socket.io-client/engine.io-client/ws": "^8.17.1",
"micromatch": "4.0.8",
"send": "0.19.0"
"send": "0.19.0",
"ethereumjs-util/**/secp256k1": "3.8.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When looking closer, this is only here because of a pinning to an ancient [email protected]. I propose we start with just lifting that pin and then look at upgrading.

Copy link
Contributor

@legobeat legobeat Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried just bumping to ethereumjs-util@^6.2.0 here but that uncovered a type error in the build about what looks like existing mismatching major versions of bn.js.
Follow-up which removes all usage of secp256k1 v3.x:

@legobeat legobeat force-pushed the ellul/resolve-secp256k1 branch 2 times, most recently from 6648565 to e2ac6ad Compare October 21, 2024 22:58
legobeat
legobeat previously approved these changes Oct 21, 2024
View reviewed changes
@legobeat
Revert "fix: unpin ethereumjs-util"
da4d7f4 
This reverts commit bf8b76b.

The bump unearths mismatching bn.js versions as type error in build
@legobeat legobeat mentioned this pull request Oct 21, 2024
Closed
7 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: da4d7f4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/82f52108-efc2-4aad-adc5-a3b35574b7b9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

This was referenced Oct 21, 2024
Closed
Draft
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salimtb salimtb salimtb approved these changes

@legobeat legobeat legobeat approved these changes

@tommasini tommasini Awaiting requested review from tommasini

Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Status: Review finalised - Ready to be merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NicholasEllul @salimtb @tommasini @legobeat @sahar-fehri