Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

MegaMek / megamek Public

Notifications You must be signed in to change notification settings
Fork 293
Star 307

Code
Issues 951
Pull requests 10
Actions
Projects 1
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Wiki
Security
Insights

Fix 6434 and 3890: pilot rolls reported before all attacks#6439

Merged

Sleet01 merged 6 commits intoMegaMek:masterMegaMek/megamek:masterfrom Sleet01:Fix_6434_Pilot_Rolls_reported_before_all_attacksSleet01/megamek:Fix_6434_Pilot_Rolls_reported_before_all_attacksCopy head branch name to clipboard

Jan 26, 2025

+172-161

Conversation Commits6 (6)Checks Files changed

Commits

Commits on Jan 26, 2025

Initial pass at fix for reporting Pilot Rolls before attacks
Sleet01
committed
Clean up changes and ensure Pilot Rolls get into both the gameManager and game logs
Sleet01
committed
Revert prior "fix", embrace making doSkillCheckInPlace() not _write_ in place
Sleet01
committed
Also apply same fix to resolve MegaMek#3890
Sleet01
committed
Rename class-level vPhaseReport to mainPhaseReport to differentiate from the umpteen thousand locally-defined variables with the same name
Sleet01
committed
Change names of internal references in updated functions, for clarity
Sleet01
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.