Fix 6434 and 3890: pilot rolls reported before all attacks

[Sleet01]

This set of fixes cleans up some of what appear to mistakes in how certain critical effects and PSR results are reported.

The issue is that a number of functions within TWGameManager.java used to write directly to vPhaseReport (the class member, not the various identically named local Vector instances, thanks for that) or use the addReport() function to the same effect, while most of the rest of the code has been updated to pass a per-Phase Vector of reports around, or compose one from the results of calling all the various handling functions.

This fix should clear up two specific instances of Pilot Skill checks appearing in the phase report log prior to the attacks that actually caused them.

NOTE: there are likely many more such functions within TWGameManager.java that need to be examined, and possibly updated:

• Any function that can be called within the Movement Phase and the Attack Handling Phase; that
• returns a non-Vector result, and/or
• calls addReport or vPhaseReport.addAll() on the class member itself.

Unfortunately, there are some 700+ such locations to check within the class.

Prior behaviour:

Updated behaviour:

Testing:

• Ran version of repro reported in [Issue] Results of VTOL Pilot hit playing out before the pilot hit actually happens. #6434
• Ran all 3 projects' unit tests

Close #3890 #6434

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.46%. Comparing base (732e576) to head (a0765d0).
Report is 17 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6439      +/-   ##
============================================
- Coverage     28.46%   28.46%   -0.01%     
  Complexity    14199    14199              
============================================
  Files          2797     2798       +1     
  Lines        274834   274846      +12     
  Branches      48632    48624       -8     
============================================
+ Hits          78231    78234       +3     
- Misses       192531   192541      +10     
+ Partials       4072     4071       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.