Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change structure of pmtilesRules, allow icon sheet, require returned promise. #1015

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Change structure of pmtilesRules, allow icon sheet, require returned promise. #1015

wants to merge 5 commits into from

Commits on Nov 14, 2024

  1. Add sheet parameter to TemplatedPMTilesLayer.js

    @prushforth
    prushforth committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6d04142 View commit details
    Browse the repository at this point in the history

  2. Change expected structure of pmtilesRules.js - adds a sheet 

    Add await on loading the pmtilesRules.js stylesheet module
    @prushforth
    prushforth committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f19aaa0 View commit details
    Browse the repository at this point in the history

  3. Change the required structure of pmtilesRules.js - requires a sheet 

    that gets loaded via sheet.load(), after which all the style rules are
set and returned.  This allows style label rules to use IconSymbolizers,
however it requires a slightly awkward structure to be imposed on
a pmtiles stylesheet module.  See pmtilesRules.js, and corresponding
test stylesheet modules for more info.

Add a script to package.json to run the test web server to debug test
HTML pages as required, removing the need to drop into a console

Update pmtiles test that was not testing rendering, only a blank map
canvas. May/may not pass on linux dep on fonts and whatnot.
    @prushforth
    prushforth committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ca8571c View commit details
    Browse the repository at this point in the history

  4. Add test mvt tiles to validate that protomapsL is available to styles… 

    …heet

modules upon import.
    @prushforth
    prushforth committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    49a6fc0 View commit details
    Browse the repository at this point in the history

  5. Restructure test stylesheet module to add Sheet

    @prushforth
    prushforth committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7fbf111 View commit details
    Browse the repository at this point in the history