Change structure of pmtilesRules, allow icon sheet, require returned promise. #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add await on loading the pmtilesRules.js stylesheet module
that gets loaded via sheet.load(), after which all the style rules are set and returned. This allows style label rules to use IconSymbolizers, however it requires a slightly awkward structure to be imposed on a pmtiles stylesheet module. See pmtilesRules.js, and corresponding test stylesheet modules for more info. Add a script to package.json to run the test web server to debug test HTML pages as required, removing the need to drop into a console Update pmtiles test that was not testing rendering, only a blank map canvas. May/may not pass on linux dep on fonts and whatnot.
…heet modules upon import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1011