Case Optimization Refresh #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a brief description of the change? (also the failing tests may motivate auto-linting! 😬) |
henryleberre
force-pushed
the
caseopt-test
branch
from
eee9bc4 to
8b3cca5
Compare
|
Added. We should probably lint but I don't think a linter could have caught this error.. |
henryleberre
force-pushed
the
caseopt-test
branch
3 times, most recently
from
6ea1021 to
d4ff4ae
Compare
henryleberre
force-pushed
the
caseopt-test
branch
from
d4ff4ae to
dae6991
Compare
|
@sbryngelson This PR should be ready for review! |
sbryngelson
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--case-optimizationcases get their own build directories named using a hash of the case-optimization options they use. This removes the need to constantly re-build MFC when switching to/from case-optimization.