Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master branch generating batch scripts with incorrect order of binaries #253

Closed
wilfonba opened this issue Dec 12, 2023 · 1 comment
Closed

Master branch generating batch scripts with incorrect order of binaries #253

wilfonba opened this issue Dec 12, 2023 · 1 comment
Assignees
@henryleberre
Labels
bug Something isn't working or doesn't seem right

Comments

@wilfonba
Copy link
Collaborator

Running ./mfc.sh run case.py -e batch -a -w -# on summit generates an LSF batch file that runs syscheck -> post_process -> pre_process -> simulation. The resulting batch file is attached.
batch.txt

I've noticed this problem on my personal fork when running in batch and interactively on other machines as well.
@henryleberre
Copy link
Member

Fixed in #248.. This is because we were using set()s to store the default MFC targets. We now order them by their logical "run" order when setting the default targets parameter.

@henryleberre henryleberre added the bug Something isn't working or doesn't seem right label Dec 12, 2023
@henryleberre henryleberre self-assigned this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryleberre henryleberre

Labels
bug Something isn't working or doesn't seem right
Milestone
No milestone
Development

No branches or pull requests
2 participants
@henryleberre @wilfonba