Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Endpoint ID instead of Chain ID #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use Endpoint ID instead of Chain ID #37

wants to merge 2 commits into from

Conversation

0xemrekaya
Copy link

@0xemrekaya 0xemrekaya commented Mar 13, 2024 •
edited
Loading

Hi,

{
  "ethereum":       101,
  "arbitrum":       110,
  "optimism":       111,
  "goerli-mainnet": 154,
  "sepolia-mainnet": 161
}

is written as Chain IDs but these are endpoint ids.
Writing as chain id can confuse me and other developers.

  • chainIds.json to endpointIds.json
  • CHAIN_IDS to ENDPOINT_IDS

I just replaced them.

@0xemrekaya 0xemrekaya mentioned this pull request Mar 13, 2024
Open
@0xemrekaya
Copy link
Author

cc: @sirarthurmoney and @TRileySchwarz

@0xemrekaya 0xemrekaya changed the title Use Endpoint ID instead of Chain ID fix: use Endpoint ID instead of Chain ID Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xemrekaya