Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoint ID should be used instead of Chain ID #38

Open
0xemrekaya opened this issue Mar 13, 2024 · 0 comments
Open

Endpoint ID should be used instead of Chain ID #38

0xemrekaya opened this issue Mar 13, 2024 · 0 comments

Comments

@0xemrekaya
Copy link

0xemrekaya commented Mar 13, 2024 •
edited
Loading

Hi, when I first saw the chainIds.json file in the repo, I thought Chain IDs were used, but Endpoint IDs were used in the chainIds.json file.

This may confuse me and other developers. If Endpoint IDs are used instead of Chain IDs, this confusion will be eliminated.

I noticed this and sent a PR, could you please check the issue and the PR? Thank you.
PR link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0xemrekaya