Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing regions #56

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

harmonherring
Copy link
Contributor

  • Adds missing SEA regions to API and DataDragon
  • Alphabetizes regions
  • Fixes Vietnam language code

Copy link
Owner

@KnutZuidema KnutZuidema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #56 (495532f) into master (46f565d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #56   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          817       817           
=========================================
  Hits           817       817           
Files Changed Coverage Δ
datadragon/data_dragon.go 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KnutZuidema KnutZuidema merged commit 5f17ad4 into KnutZuidema:master Aug 28, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants