Point-and-click Sweep (first PR) #4989
Conversation
…-of-Lofts-and-Offset-Planes
This reverts commit 214763c.
…-of-Lofts-and-Offset-Planes
…-of-Lofts-and-Offset-Planes
…-of-Lofts-and-Offset-Planes
…-of-Lofts-and-Offset-Planes
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4989 +/- ##
=======================================
Coverage 85.84% 85.84%
=======================================
Files 88 88
Lines 31432 31432
=======================================
Hits 26984 26984
Misses 4448 4448
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pierremtb
changed the title
There was a problem hiding this comment.
Nice man! This came together quickly. I hit a few engine-side issues with sweep generation while testing, but the command flow seems decent other than the command palette's path argument preview text saying "1 face" instead of "1 edge", but I think that's a longer-standing issue.
First case implemented here: closed profile along a path. The user selects a profile (solid2D), then a segment, we find its parent sketch and we sweep the profile along that. More to come in subsequent PRs, hence the 'development' tag staying on.
Playwright test video:
https://github.com/user-attachments/assets/7d3e01c8-1b1a-4a3c-b149-adfd09733b34