a few fixes (thread safety & cl_khr_command_buffer UB) #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvh
reviewed
Nov 8, 2023
franz
force-pushed
the
cts_fixes
branch
2 times, most recently
from
dcff39e
to
4b4982e
Compare
|
Removed the first two commits from the PR; i did not realize there was already an open PR with those. |
franz
changed the title
franz
force-pushed
the
cts_fixes
branch
2 times, most recently
from
0309e43
to
8f4b503
Compare
|
rebased on main. should be ready for review. |
bashbaug
reviewed
Sep 30, 2024
test_conformance/extensions/cl_khr_command_buffer/command_buffer_event_sync.cpp
Outdated
Show resolved
Hide resolved
…rrier.cpp BarrierWithWaitListKHR::Run in command_buffer_test_barrier.cpp contains a "check second enqueue" which tries to zero out the cl_mems before enqueueing the command buffer again. However, the zeroing commands are enqueued to the in-order queue, while the command buffer to the out-of-order queue. Since there is no implicit or explicit sync, this is undefined behaviour.
…ync.cpp RunCombufWaitForSecQueueCombuf() is launching two clEnqueueFillBuffer commands on two separate queues, however both had the same buffer argument, and there was no synchronization between the commands. * add an event dependency to the second FillBuffer to ensure correct execution * change the fill pattern of the first FillBuffer to a different pattern
replaced static variables with stack variables
bashbaug
approved these changes
Oct 2, 2024
EwanC
approved these changes
Oct 3, 2024
|
Merging as discussed in the October 8th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some fixes we've been carrying in our CTS fork:
command_buffer_event_sync.cpp: enqueue of two commands in two separate queues, with both using the same buffer argument, and no synchronization between the commands.command_buffer_test_barrier.cpp: missing synchronization between zeroing command and command-buffer using two separate queuestest_thread_dimensions.cppthread-safe to avoid spurious errors.