Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generic_address_space, command_buffer_event_sync, test_compiler and images/test_1D_buffer #2062

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

franz
Copy link
Contributor

@franz franz commented Aug 29, 2024

fixes several issues:

  • generic_address_space test: add check for program scope variables. The test uses both generic AS and program-scope variables, however it only checked the generic-AS presence in clGetDeviceInfo.
  • compiler/test_compiler_defines_for_extensions.cpp: add cl_khr_command_buffer_multi_device to the list of recognized extensions
  • command_buffer_event_sync.cpp: add delays for testing clSetEventCallback - according to specification, these can be executed asynchronously (in a separate thread) by the OpenCL implementation, hence the event callback is not quaranteed to be called before clFinish() returns. Existing test events/test_callbacks.cpp also waits for callback with loops of usleep.
  • images/kernel_image_methods/test_1D_buffer.cpp: fix allocation size being too small for the 1D buffer backing the image

@franz
Copy link
Contributor Author

franz commented Sep 16, 2024

The code check is complaining about the extension list, however i think the existing formatting is more readable.
Edit: added // clang-format off/on

@franz franz marked this pull request as ready for review September 16, 2024 15:37
@pjaaskel
Copy link
Contributor

This and #1840 are blocking a successful conformance run for PoCL on x86_64 and Level Zero.

@franz
Copy link
Contributor Author

franz commented Oct 1, 2024

Dropped the conflicting commit & rebased onto main.

@bashbaug
Copy link
Contributor

bashbaug commented Oct 1, 2024

Merging as discussed in the October 1st teleconference.

@bashbaug bashbaug merged commit 2be73b2 into KhronosGroup:main Oct 1, 2024
7 checks passed
@franz franz deleted the cts_fixes3 branch October 18, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants