Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Port HazReg.jl #4

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

[Feat] Port HazReg.jl #4

wants to merge 28 commits into from

Conversation

lrnv
Copy link
Member

@lrnv lrnv commented Jun 12, 2024 •
edited
Loading

Checklist for the porting:

  • Bring the code in, including the documentation and examples
  • Make use of the type system to differentiate between the several models.
  • Produce a vector interface
  • Adapt the documentation to the vector interface to be able to
  • Check that the results are OK
  • Produce the StatsAPI.fit and @formula interface: warning there are two formulas for two predictors.
  • Produce tests to ensure that it is indeed working correctly.

lrnv added 2 commits June 12, 2024 11:53
@lrnv
[Feat] Port HazReg.jl
9d5eca6 
There is a lot of things to do to port it correclty:

- bring the code in
- modify the interface to use `StatsAPI.fit(HazardRegression, @formula(Surv(time,status)~covariates)`
- port the documentation
@lrnv
add new file
8231ed0
@lrnv lrnv mentioned this pull request Jun 12, 2024
Closed
FJRubio67 and others added 26 commits July 2, 2024 16:40
@FJRubio67 @lrnv
Initial commit
31c42c9
@lrnv
few modifications to match the format
42bf9a1
@lrnv
add test
f3b5b8c
@lrnv
first shot at interface (probably not wokring)
b723979
@lrnv
add coments for the confidneenc interval
6d825a6
@lrnv
everything works but coef sign wrong ?
cacf6f9
@lrnv
was a copying mistake :)
ffeba00
@lrnv
fix project.toml
ab78923
@lrnv
add correct documentations
c3bbf19
@lrnv
add css
6af55d5
@lrnv
add atol
30b4ba7
@lrnv
recuce atol
35d4703
@lrnv
potential for sorting ?
6cf28a7
@lrnv
sorting but still have ties issues
9be0880
@lrnv
correct mistake on 1.6
bd08d10
@lrnv
first rewrite
f3762ee
@lrnv
up
ec31355
@lrnv
up julia dependency
ddbdc91
@lrnv
errr
d10f29f
@lrnv
move to stableRNG for julia 1.6
6fb388d
@lrnv
[Feat] Port HazReg.jl
f4b4a79 
There is a lot of things to do to port it correclty:

- bring the code in
- modify the interface to use `StatsAPI.fit(HazardRegression, @formula(Surv(time,status)~covariates)`
- port the documentation
@lrnv
add new file
4e0ce05
@lrnv
Merge branch 'port_hazreg' of https://github.com/JuliaSurv/SurvivalMo…
fa1da73 
…dels.jl into port_hazreg
@lrnv
import code -- not working yet
cbc70b7
@lrnv
first shot at rewrite
7d5292c
@lrnv
now it compiles
9423dcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrnv @FJRubio67