Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix Intersect Filter #40

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Bug Fix Intersect Filter #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26aefb3
Fix initial value of high counter
theHenks Feb 28, 2024
ba1fe2f
Include assert if intersect still fails
theHenks Feb 28, 2024
c6f8d23
Remove comments
theHenks Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/intersect.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

cand_pos::Int = firstindex(Y) + 1
intersect_pos::Int = firstindex(Y) + 1
y_high_counter::Int = ifelse(first(Y) > threshold, min_n_over_thresh + 1, 0)
y_high_counter::Int = ifelse(first(Y) >= threshold, min_n_over_thresh + 1, 0)

Check warning on line 48 in src/intersect.jl

View check run for this annotation

Codecov / codecov/patch

src/intersect.jl#L48 

Added line #L48 was not covered by tests

n_intersects::Int = 0
@inbounds for i in eachindex(Y)
Expand Down
Loading