Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix Intersect Filter #40

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

theHenks
Copy link
Contributor

The initial condition of y_high_counter checks for > threshold, while the update condition of y_is_high in the loop checks for >= threshold.
In cases, where the first value of the waveform is exactly the threshold value, this return the first index as result, which throws an error in the @assert at the end of the loop.
This is fixed now.
The error occurs in case the waveform of the FADC saturates and has 0s exclusively.
Bug found by @LisaSchlueter and fixed by @fhagemann :)

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.27%. Comparing base (045a1dd) to head (c6f8d23).
Report is 3 commits behind head on main.

Files Patch % Lines
src/intersect.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   52.94%   53.27%   +0.33%     
==========================================
  Files          29       29              
  Lines         986      993       +7     
==========================================
+ Hits          522      529       +7     
  Misses        464      464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz oschulz merged commit 339b486 into JuliaPhysics:main Feb 28, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants