Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial condition of
y_high_counter
checks for> threshold
, while the update condition ofy_is_high
in the loop checks for>= threshold
.In cases, where the first value of the waveform is exactly the threshold value, this return the first index as result, which throws an error in the
@assert
at the end of the loop.This is fixed now.
The error occurs in case the waveform of the FADC saturates and has 0s exclusively.
Bug found by @LisaSchlueter and fixed by @fhagemann :)