-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temp fix for #8690: added uv.h and dependencies to distribution. #9221
Conversation
Ref how this was done before #8024 which took this out of the install. We probably don't want to do this when we're using a system libuv, though we have a bunch of work to do to reconcile our fork with upstream to make this realistically possible. |
Maybe you could put the install command within an |
@tkelman, @nalimilan, thanks for the inputs. I'll amend accordingly. |
bump |
Why do we need to install libuv.a? |
@JeffBezanson, we don't need to install libuv.a for my purposes. This was my attempt to follow @tkelman 's recommendation of taking #8024 as the guide for getting uv.h and friends back. I'll remove the libuv.a part. |
I could use |
Temp fix for #8690: added uv.h and dependencies to distribution.
shall we @JuliaBackports this while #8880 is pending? |
If a temporary fix is used on |
I'll prep a PR for the backport. |
A stopgap measure while #8880 is pending.
Should address #8690.