Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp fix for #8690: added uv.h and dependencies to distribution. #9221

Merged
merged 2 commits into from
Dec 12, 2014

Conversation

twadleigh
Copy link
Contributor

A stopgap measure while #8880 is pending.
Should address #8690.

@twadleigh twadleigh changed the title Added uv.h and dependencies to distribution. WIP: Added uv.h and dependencies to distribution. Dec 2, 2014
@twadleigh twadleigh changed the title WIP: Added uv.h and dependencies to distribution. Temp fix for $8690: added uv.h and dependencies to distribution. Dec 2, 2014
@twadleigh twadleigh changed the title Temp fix for $8690: added uv.h and dependencies to distribution. Temp fix for #8690: added uv.h and dependencies to distribution. Dec 2, 2014
@tkelman
Copy link
Contributor

tkelman commented Dec 2, 2014

Ref how this was done before #8024 which took this out of the install. We probably don't want to do this when we're using a system libuv, though we have a bunch of work to do to reconcile our fork with upstream to make this realistically possible.

@nalimilan
Copy link
Member

Maybe you could put the install command within an ifeq($(USE_SYSTEM_LIBUV),0) block so that it doesn't get installed when one day all patches will have been moved upstream.

@twadleigh
Copy link
Contributor Author

@tkelman, @nalimilan, thanks for the inputs. I'll amend accordingly.

@twadleigh
Copy link
Contributor Author

bump

@JeffBezanson
Copy link
Member

Why do we need to install libuv.a?

@twadleigh
Copy link
Contributor Author

@JeffBezanson, we don't need to install libuv.a for my purposes. This was my attempt to follow @tkelman 's recommendation of taking #8024 as the guide for getting uv.h and friends back. I'll remove the libuv.a part.

@tkelman
Copy link
Contributor

tkelman commented Dec 11, 2014

I could use libuv.a to save about a minute on appveyor, but I don't think anyone else was using it.

JeffBezanson added a commit that referenced this pull request Dec 12, 2014
Temp fix for #8690: added uv.h and dependencies to distribution.
@JeffBezanson JeffBezanson merged commit 0e78bb3 into JuliaLang:master Dec 12, 2014
@tkelman
Copy link
Contributor

tkelman commented Dec 12, 2014

shall we @JuliaBackports this while #8880 is pending?

@twadleigh twadleigh deleted the uv.h branch December 12, 2014 12:25
@ivarne
Copy link
Member

ivarne commented Dec 12, 2014

If a temporary fix is used on master, I think it should be acceptable on release-0.3 also.

@twadleigh
Copy link
Contributor Author

I'll prep a PR for the backport.

@twadleigh twadleigh restored the uv.h branch December 12, 2014 19:20
tkelman added a commit that referenced this pull request Dec 15, 2014
@twadleigh twadleigh deleted the uv.h branch September 5, 2016 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants