Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid libuv dependency in julia.h #12987

Closed
Keno opened this issue Sep 6, 2015 · 3 comments · Fixed by #42963
Closed

Avoid libuv dependency in julia.h #12987

Keno opened this issue Sep 6, 2015 · 3 comments · Fixed by #42963

Comments

@Keno
Copy link
Member

Keno commented Sep 6, 2015

julia.h currently depends on uv.h through support/ios.h. It also declares a number of functions that take uv pointers as parameters. It would be good to decouple this, so we don't include uv.h by default, since it pulls in a number of system headers that may not be compatible with other libraries (e.g. it pulls in some mach headers that can confuse LLVM on OS X).
@tkelman
Copy link
Contributor

tkelman commented Sep 7, 2015

ref #8880 #8690 #8754 #9221

@mbauman
Copy link
Member

mbauman commented Apr 9, 2021

This seems to have been addressed at some point; julia.h no longer includes support/ios.h (nor any header that includes it to my eyes).

@mbauman mbauman closed this as completed Apr 9, 2021
@vtjnash vtjnash reopened this Apr 9, 2021
@vtjnash
Copy link
Member

vtjnash commented Apr 9, 2021

It is in libsupport.h now

@vtjnash vtjnash mentioned this issue Nov 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Progress towards header cleanup JuliaLang/julia
4 participants
@mbauman @vtjnash @Keno @tkelman