fix deprecation of dtc (#380)

* 0.5.19: fix deprecation of `dtc`
JuliaGaussianProcesses · Sep 25, 2023 · 6becdc2 · 6becdc2 · st-- · Sep 25, 2023
1 parent 083c772
commit 6becdc2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "AbstractGPs"
 uuid = "99985d1d-32ba-4be9-9821-2ec096f28918"
 authors = ["JuliaGaussianProcesses Team"]
-version = "0.5.18"
+version = "0.5.19"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

diff --git a/src/deprecations.jl b/src/deprecations.jl
@@ -6,5 +6,17 @@
     plt, gp; samples=n, kwargs...
 )
 
-@deprecate elbo(dtc::DTC, fx, y) approx_log_evidence(dtc, fx, y)
-@deprecate dtc(vfe::Union{VFE,DTC}, fx, y) approx_log_evidence(vfe, fx, y)
+@deprecate dtc(dtc::DTC, fx, y) approx_log_evidence(dtc, fx, y)
+
+function _warn_elbo_called_with_DTC(dtc::DTC, fx, y)
+    @warn "`elbo` was called with an object of type `DTC`, but should only be called with the `VFE` type instead"
+    return elbo(VFE(dtc.fz), fx, y)
+end
+
+function _warn_dtc_called_with_VFE(vfe::VFE, fx, y)
+    @warn "`dtc` was called with an object of type `VFE`, but instead you should call `approx_log_evidence` with an object of type `DTC`"
+    return approx_log_evidence(DTC(vfe.fz), fx, y)
+end
+
+@deprecate elbo(dtc::DTC, fx, y) _warn_elbo_called_with_DTC(dtc, fx, y)
+@deprecate dtc(vfe::VFE, fx, y) _warn_dtc_called_with_VFE(vfe, fx, y)