-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RawBearer API #4395
Open
tdammers
wants to merge
23
commits into
master
Choose a base branch
from
tdammers/raw-bearer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RawBearer API #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdammers
force-pushed
the
tdammers/raw-bearer
branch
from
February 24, 2023 14:42
98f55de
to
53b2ef0
Compare
tdammers
force-pushed
the
tdammers/raw-bearer
branch
from
March 22, 2023 15:32
53b2ef0
to
82864b3
Compare
tdammers
force-pushed
the
tdammers/raw-bearer
branch
7 times, most recently
from
May 3, 2023 15:06
8232b17
to
c5fc556
Compare
coot
reviewed
May 12, 2023
ouroboros-network-framework/changelog.d/20230224_094922_tdammers_raw_bearer.rst
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/RawBearer.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/RawBearer.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/RawBearer.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/RawBearer.hs
Outdated
Show resolved
Hide resolved
coot
approved these changes
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It can be merged once CI passes, we should merge it after #4571. |
tdammers
force-pushed
the
tdammers/raw-bearer
branch
from
May 30, 2023 11:21
78b5624
to
e9262c8
Compare
coot
reviewed
Jun 1, 2023
tdammers
force-pushed
the
tdammers/raw-bearer
branch
from
June 1, 2023 10:05
c8b8416
to
05cc47a
Compare
tdammers
force-pushed
the
tdammers/raw-bearer
branch
from
June 9, 2023 09:31
dad13cf
to
712308a
Compare
tdammers
force-pushed
the
tdammers/raw-bearer
branch
from
June 21, 2023 12:19
e9d6fb9
to
bd14316
Compare
There's a conflict in |
coot
previously requested changes
Jul 7, 2023
ouroboros-network-framework/test/Test/Ouroboros/Network/RawBearer.hs
Outdated
Show resolved
Hide resolved
@tdammers do we still need this PR? |
Lower-level send/receive API for Snockets, bypassing the normal Mux protocol. We need this for KES secure forgetting, as we cannot store secrets in intermediate data structures for serialization purposes; we must copy data directly between secure memory and file descriptors.
tdammers
force-pushed
the
tdammers/raw-bearer
branch
from
October 21, 2024 11:51
a5550a8
to
9810b71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This provides a socket-like API for Snockets (backed by sockets / named pipes, or simulated in IOSim), reading/writing directly to/from raw memory buffers.
This will be needed to securely send KES keys over a network connection or local pipe, because we need to ensure that key data is never stored on disk, nor on the GHC heap, from where it might be swapped to disk.
For context, see also:
Checklist
changelog.d
directory created usingscriv
. If in doubt, see the Consensus release process.interface-CHANGELOG.md