Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release ouroboros-network #4573

Merged
merged 1 commit into from
May 26, 2023
Merged

Release ouroboros-network #4573

merged 1 commit into from
May 26, 2023

Conversation

coot
Copy link
Contributor

@coot coot commented May 26, 2023

Description

Prepare to release ouroboros-network-0.8.0.0.

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@coot coot requested a review from bolt12 May 26, 2023 10:59
bolt12
bolt12 approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about #4395?

cardano-ping/CHANGELOG.md Outdated Show resolved Hide resolved
@bolt12
Copy link
Contributor

bolt12 commented May 26, 2023

I approved but still needs changes, please note that. I should have asked for changes instead @coot

@coot
Copy link
Contributor Author

coot commented May 26, 2023

I don't want to include #4395 in 0.8.

@coot coot enabled auto-merge May 26, 2023 11:03
@coot coot added this pull request to the merge queue May 26, 2023
Merged via the queue into master with commit 367c2c2 May 26, 2023
@coot coot deleted the coot/on-0.8.0.0 branch May 26, 2023 12:39
@coot coot added the networking label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coot @bolt12