-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Shelley genesis info from the ledger configuration #4091
Open
bartfrenk
wants to merge
19
commits into
master
Choose a base branch
from
bartfrenk/3976/remove-shelley-genesis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer needed as of [this PR](#4007)
... since this is no longer defined. We have a `ShelleyBasedEra` symbol, but that refers to a type class.
... add a FIXME that should be addressed before this PR is merged.
I do not know if we should mention 'ProtocolTransitionParamsShelleyBased' here instead.
bartfrenk
force-pushed
the
bartfrenk/3976/remove-shelley-genesis
branch
from
October 27, 2022 13:16
f59ec93
to
a1588d9
Compare
bartfrenk
force-pushed
the
bartfrenk/3976/remove-shelley-genesis
branch
2 times, most recently
from
November 14, 2022 10:22
5d3ebad
to
f762ce0
Compare
To avoid breaking backwards-compatibility of the interface we add ShelleyGenesis to BlockConfig, and use that to serve the GetGenesisConfig query.
bartfrenk
force-pushed
the
bartfrenk/3976/remove-shelley-genesis
branch
from
November 14, 2022 10:46
f762ce0
to
41ff462
Compare
bartfrenk
added a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 14, 2022
Change is required for a simpler consensus LedgerConfig here: IntersectMBO/ouroboros-network#4091.
bartfrenk
added a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 21, 2022
… ShelleyGenesis instances To support the ouroboros-network PR here: IntersectMBO/ouroboros-network#4091
bartfrenk
added a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 22, 2022
… ShelleyGenesis instances To support the ouroboros-network PR here: IntersectMBO/ouroboros-network#4091
bartfrenk
added a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 22, 2022
… ShelleyGenesis instances To support the ouroboros-network PR here: IntersectMBO/ouroboros-network#4091
bartfrenk
added a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 23, 2022
… ShelleyGenesis instances To support the ouroboros-network PR here: IntersectMBO/ouroboros-network#4091
dnadales
force-pushed
the
nfrisby/issue-3962-conway
branch
from
December 20, 2022 16:49
634ea6c
to
93c9adc
Compare
dnadales
force-pushed
the
nfrisby/issue-3962-conway
branch
from
December 29, 2022 10:13
0c4fdc4
to
2a0eae7
Compare
dnadales
force-pushed
the
nfrisby/issue-3962-conway
branch
2 times, most recently
from
February 1, 2023 10:29
49da2d6
to
903bcc6
Compare
What is the status of this PR? IntersectMBO/cardano-ledger#3053 has been merged and now I am trying to integrate newest ledger, but I am running into inability of consensus to handle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes IntersectMBO/ouroboros-consensus#409. Requires IntersectMBO/cardano-ledger#3053.
This PR does three things:
ShelleyGenesis
from theShelleyLedgerConfig
.ShelleyGenesis
toShelleyBlockConfig
and reimplementsGetGenesisConfig
in terms of thatShelleyGenesis
value.TranslateEra * ShelleyGenesis
instances in the aforementionedcardano-ledger
PR.The first and third points close IntersectMBO/ouroboros-consensus#409. The second point keeps the (query) interface backwards compatible.
Checklist