-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation context to translate from Byron to Shelley #3164
Conversation
58725b7
to
bb4bd92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thank you @bartfrenk ! Could you add something to the CHANGELOG about this change? thanks!
|
6afd52c
to
e450dba
Compare
@bartfrenk thanks again! Should I merge this as soon an CI clears? (I don't plan on letting the darwin failure stop us from merging). I'll probably squash all the commits (they started out as logical units, but appeasing CI caused it to be a bit scattered :) ) |
0b8bb44
to
13a02b0
Compare
844103a
to
eb54442
Compare
eb54442
to
1e3c099
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ledger has changed since this PR was originally opened.
In #3224 we switched parameterization of ShelleyGenesis
from era to crypto. Same thing is needed for FromByronTransitionContext
, since that type is only valid for ShelleyEra
. Also TranslateEra
instances has been removed, also for the reason listed above.
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
a323075
to
919d8a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Looks great!
This PR does two things:
TranslationContext
for theShelleyEra
to allow for translating from Byron into the first Shelley era.It removes theDone in Mempool: Bound ex units of chosen transactions when forging new block ouroboros-network#3224TranslateEra
instances forShelleyGenesis
.Closes IntersectMBO/ouroboros-consensus#409. In short, it is required for removing the entire
ShelleyGenesis
value from theShelleyLedgerConfig
inouroboros-consensus
. Closes IntersectMBO/ouroboros-consensus#409.There is a PR in ouroboros-consensus: IntersectMBO/ouroboros-network#4091 which require the (backported) changes from this PR.