Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

566 update flood input to non structural damage for combined wind wave surge building damage docs #394

Conversation

longshuicy
Copy link
Member

Work with this pyincore PR: IN-CORE/pyincore#577

@navarroc
Copy link
Member

navarroc commented May 23, 2024

I found one issue with non structural building damage. When I ran the Galveston community app retrofit notebook, I realized non structural damage does not support "retrofit_strategy" as an input parameter. Should we open another issue or do that as part of the pyincore PR?

@longshuicy longshuicy self-assigned this May 23, 2024
Copy link
Member

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with IN-CORE/pyincore#571 and everything looks to be working. Tested all updated notebooks.

Copy link
Member

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All notebooks worked

@ywkim312 ywkim312 merged commit 19c1050 into develop May 24, 2024
1 check passed
@ywkim312 ywkim312 deleted the 566-update-flood-input-to-non-structural-damage-for-combined-wind-wave-surge-building-damage-docs branch May 24, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update flood input to non structural damage for combined wind wave surge building damage
3 participants