Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtkspell3: add missing build dep gtk-doc and license #78388

Merged
merged 1 commit into from
May 30, 2021

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented May 30, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Seen in #72535 and reproduced locally.

@BrewTestBot BrewTestBot added the missing license Formula has a missing license which should be added label May 30, 2021
@carlocab
Copy link
Member

I'm confused as to how we were able to build this successfully before without this dependency.

@cho-m cho-m mentioned this pull request May 30, 2021
5 tasks
@cho-m
Copy link
Member Author

cho-m commented May 30, 2021

I am thinking one of the other dependencies previously pulled in gtk-doc and it was removed?
Haven't taken a good look yet.

@cho-m cho-m force-pushed the gtkspell3-add-dependency branch from f20a27a to 7d4e9e1 Compare May 30, 2021 16:42
@cho-m cho-m changed the title gtkspell3: add missing build dep gtk-doc gtkspell3: add missing build dep gtk-doc and license May 30, 2021
@BrewTestBot BrewTestBot removed the missing license Formula has a missing license which should be added label May 30, 2021
@carlocab carlocab added automerge-skip `brew pr-automerge` will skip this pull request bottle unneeded [DEPRECATED] Bottle does not need to be built labels May 30, 2021
@carlocab
Copy link
Member

I suspect we don't need new bottles for this one. However, if you disagree, feel free to remove the labels.

@carlocab carlocab added the license License PRs label May 30, 2021
@carlocab carlocab merged commit f524470 into Homebrew:master May 30, 2021
@cho-m cho-m deleted the gtkspell3-add-dependency branch May 30, 2021 18:03
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request bottle unneeded [DEPRECATED] Bottle does not need to be built license License PRs outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants