Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: set MacOS env variables only on macOS #78107

Closed
wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented May 26, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@iMichka iMichka added the linux to homebrew-core Migration of linuxbrew-core to homebrew-core label May 26, 2021
Formula/rust.rb Outdated Show resolved Hide resolved
@cho-m
Copy link
Member

cho-m commented May 30, 2021

It looks like most failures are expected, so may want to check to see if safe to merge
The failures I haven't taken a look at:

  • openimageio
  • graph-tool - errors are about boost

The failures that are maybe safe to ignore:

Once this PR is merged, we can try continuing #76780 after rebase and some fixes

@carlocab
Copy link
Member

Changes included in #76780.

@carlocab carlocab closed this May 31, 2021
@iMichka iMichka deleted the rust branch May 31, 2021 20:35
@cho-m cho-m mentioned this pull request Jun 1, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linux to homebrew-core Migration of linuxbrew-core to homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants