-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
djl-serving: fix sha256 mismatch #76668
Conversation
We'll need to know why they retagged and if it wasn't malicious. Please make an issue upstream. |
Pending on upstream to comment in deepjavalibrary/djl#941 |
@SMillerDev according to deepjavalibrary/djl#941 (comment) (quoted below), the previous tar was from a snapshot and ended up being updated in-place with 0.11.0 release.
I will probably wait for any last comments on whether they want to upload a new file or not. |
Can we update the hash of the file without releasing the new version ? Like it's been done in the commit, it can go as a revision ? |
Yes. |
I see! I'm one of the contributors and the one who added the djl-serving homebrew package. The upstream tarball is alright now. We can merge this PR with the new sha hash and the new revision. Let me know if we can help in any way. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?One of failures seen in OpenJDK 16 CI run: #72535 (comment)
Looking at the GitHub latest: https://github.com/deepjavalibrary/djl/releases/tag/v0.11.0
The same tag was updated on May 3rd, but this formula was added on March 24 - #73649
So, it may have been updated in-place.
https://search.maven.org/artifact/ai.djl/serving