Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Homebrew] Checking into uploaded djl-serving v0.11.0 SHA difference #941

Closed
cho-m opened this issue May 5, 2021 · 4 comments
Closed

[Homebrew] Checking into uploaded djl-serving v0.11.0 SHA difference #941

cho-m opened this issue May 5, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@cho-m
Copy link

cho-m commented May 5, 2021

At Homebrew, we are seeing a SHA mismatch described here: Homebrew/homebrew-core#76668
This is for the file: https://djl-ai.s3.amazonaws.com/publish/djl-serving/serving-0.11.0.tar

Due to security reasons, we would like to confirm the reason for retagging / SHA difference.

I see that the djl-serving formula was added back in March to download v0.11.0, while this GitHub repo shows that v0.11.0 released in May.

For reference, the Homebrew formula for djl-serving is available at:
https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/djl-serving.rb
It was added with v0.11.0 in PR Homebrew/homebrew-core#73649

@aksrajvanshi
Copy link
Contributor

@frankfliu did we make any changes to the djl-serving tar file recently ?

@frankfliu
Copy link
Contributor

Yes this is a bug:

  1. When we publish djl-serving brew package, it was based on 0.11.0-SNAPSHOT on March 23
  2. On May, we updated djl-serving binary to 0.11.0 release version, but we didn't update brew package

What we can do is release a version 0.11.0-post1 in brew to address this issue.

@frankfliu frankfliu added the bug Something isn't working label May 5, 2021
@cho-m
Copy link
Author

cho-m commented May 5, 2021

@frankfliu
On Homebrew side, it is possible to just update SHA in linked PR once we have confirmation that this was an intended modification. Homebrew's revision option allows us to push out an update even when version isn't changed.

For future updates, it would be best to make sure to use a new filename for updates once published, otherwise the Homebrew Formula will break. This is especially the case for unbottled formulas like this.

@aksrajvanshi
Copy link
Contributor

A new revision has been created on homebrew's side. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants