add precursor ppm accuracy and precision #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe align the name wording to the other distribution parameter QC metric terms? |
|
👍 |
edeutsch
reviewed
Apr 12, 2024
bittremieux
requested changes
Apr 14, 2024
There was a problem hiding this comment.
@cbielow Can you make the naming changes that Eric requested? Other than that it looks good to me.
bittremieux
approved these changes
Apr 14, 2024
bittremieux
requested changes
Apr 14, 2024
|
should be good to go now |
bittremieux
approved these changes
Apr 15, 2024
edeutsch
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #241
I've opted to add a
precisionterm, which I'm not sure is needed, but since there isaccuracyalready, I thought there is no harm.However, those two terms are rather narrow, but maybe that's ok. I used a free ID slot (MS:1000394).
We can also remove the precision annotation if desired. I have no strong opinion, but I think may add some helpful context.