-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weaviate guide - code and examples #1365
Conversation
Here is the summary of changes. You are about to add 18 region tags.
This comment is generated by snippet-bot.
|
@ganochenkodg this is for an upcoming GKE tutorial, correct? |
Yes, for upcoming guide, @bourgeoisor review it pls |
@@ -0,0 +1,16 @@ | |||
FROM python:3.12-slim-bookworm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create a new workflow for this weaviate samples, that has 4 steps:
- 2x
docker build
steps for the two containers - 2x
terraform validate
steps for the two terraform directories
You can find an example here: https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/blob/main/.github/workflows/cost-optimization-gke-vpa-recommendations-ci.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, sure, will add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TF code and yaml manifests for Weaviate