Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weaviate guide - code and examples #1365

Merged
merged 29 commits into from
Aug 15, 2024
Merged

Conversation

ganochenkodg
Copy link
Contributor

TF code and yaml manifests for Weaviate

@ganochenkodg ganochenkodg requested review from yoshi-approver and a team as code owners July 4, 2024 12:35
Copy link

snippet-bot bot commented Jul 4, 2024

Here is the summary of changes.

You are about to add 18 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bourgeoisor
Copy link
Member

@ganochenkodg this is for an upcoming GKE tutorial, correct?
ping me when the PR is ready for review

@ganochenkodg
Copy link
Contributor Author

ganochenkodg commented Jul 25, 2024

@ganochenkodg this is for an upcoming GKE tutorial, correct? ping me when the PR is ready for review

Yes, for upcoming guide, @bourgeoisor review it pls

@@ -0,0 +1,16 @@
FROM python:3.12-slim-bookworm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a new workflow for this weaviate samples, that has 4 steps:

  • 2x docker build steps for the two containers
  • 2x terraform validate steps for the two terraform directories

You can find an example here: https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/blob/main/.github/workflows/cost-optimization-gke-vpa-recommendations-ci.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, sure, will add

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bourgeoisor bourgeoisor merged commit 98a5663 into GoogleCloudPlatform:main Aug 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants