Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked descriptions #76

Closed
wants to merge 79 commits into from
Closed

Tweaked descriptions #76

wants to merge 79 commits into from

Conversation

4Luke4
Copy link
Contributor

@4Luke4 4Luke4 commented May 17, 2019

This is a collection of various tweaks/fixes for some opcodes.
I'd like to credit the user "kjeron" (Beamdog Forums/Gibberlings3) for providing this detailed information.

appendices/timers.htm Outdated Show resolved Hide resolved
@@ -1747,12 +1747,12 @@
</tr>
<tr>
<td>2</td>
<td> <span class="unknown">Unknown</span></td>
<td> Damage strength bonus (BGEE)</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two different from "Add strength bonus" at bit 0 that they just split the bonus? If you want to apply just the to-hit or the damage one, while 0 does both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two different from "Add strength bonus" at bit 0 that they just split the bonus? If you want to apply just the to-hit or the damage one, while 0 does both?

Yes, they allow for splitting the bonus (EE only though)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add that to their descriptions then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the original ignored the strength to-hit bonus for ranged weapons for that bit. Is that still true with the split bits or do they override this behaviour?

@lynxlynxlynx
Copy link
Member

Do you plan to fix the remaining problems? The few that require research can be mostly ignored.

@4Luke4
Copy link
Contributor Author

4Luke4 commented Jun 8, 2019

Do you plan to fix the remaining problems? The few that require research can be mostly ignored.

Yes, sure.
In any case, feel free to make your own edits where appropriate (for instance, every time you think I put too many "technicalities".....)

@lynxlynxlynx
Copy link
Member

I've fixed it up and finally merged it, thanks.

@4Luke4
Copy link
Contributor Author

4Luke4 commented Aug 20, 2019

I've fixed it up and finally merged it, thanks.

You're welcome.

I'll create another Pull Request as soon as I've gathered enough new information.....

@burner1024 burner1024 mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants