Empty input #433
Merged
Empty input #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taepper
force-pushed
the
insertions-out-of-metadata
branch
from
c86ed18 to
e8680f0
Compare
Taepper
force-pushed
the
insertions-out-of-metadata
branch
2 times, most recently
from
8c6a42f to
d2ecf3a
Compare
fengelniederhammer
force-pushed
the
insertions-out-of-metadata
branch
from
d2ecf3a to
4e29220
Compare
Taepper
force-pushed
the
empty-input
branch
4 times, most recently
from
3116e01 to
d6898ca
Compare
Closed
Taepper
force-pushed
the
empty-input
branch
2 times, most recently
from
ff7715e to
dd5cd6c
Compare
fengelniederhammer
requested changes
May 28, 2024
Taepper
force-pushed
the
empty-input
branch
3 times, most recently
from
4ea4eea to
d996531
Compare
|
Can I already test this works? Are there any breaking changes or can I just use the docker image as is? |
corneliusroemer
added a commit
to loculus-project/loculus
that referenced
this pull request
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #244
Summary
We want to be able to start without data, such that downstream packages do not need extra logic.
In particular the ingest with an empty ndjson (which does not have keys anymore) should not fail. This was challenging, because we never want to read the ndjson files into a table as a whole, but only the non-sequence columns of it, and the sequence columns should be compressed while reading them
PR Checklist
- [ ] All necessary documentation has been adapted or there is an issue to do so.