-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump lapis-silo to 0.2.2 to allow empty input in silo-preprocessing #2073
Conversation
You should retest now :) |
Retriggering |
9682387
to
b169312
Compare
You might want to delete the preview and recreate it |
e7cc7ed
to
96bf594
Compare
I still see 503 from https://lapis-empty-input.loculus.org/dummy-organism/sample/details is that what you expect because we haven't adjusted the thing that prepares the data to import? |
My gut feeling was that this was expected? What works now is silo preprocessing, it no longer crashes. But you're right @theosanderson, this problem doesn't look entirely solved. SILO/LAPIS shouldn't 503 when there's no data available. It should simply do what one expects when there's no data. Return nothing. The PR mentions:
@Taepper can you enlighten us? |
Are we actually preparing an empty dataset for SILO to import? My idea was that maybe we weren't, but if you say it was crashing before then I guess we were |
Yeah it crashed and as a result we didn't update the output but discarded. Now it doesn't crash, so we use the output. But now SILO-proper crashes. I guess we've pushed the error down one step, but still way to go to LAPIS 🙃 First SILO, then LAPIS. It's possible that SILO can actually deal with the empty input and it's now a LAPIS bug. I don't know. @chaoran-chen / @Taepper might be able to tell :) |
96bf594
to
7a5fc87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as it seems ok to bump, regardless of this Q
GenSpectrum/LAPIS-SILO#433
https://empty-input.loculus.org
Works!
Let's get it merged @Taepper soon, congrats!