Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ecs): flip SystemBuilder::before and SystemBuilder::after docs #1377

Merged
merged 1 commit into from
Nov 22, 2024
Merged

docs(ecs): flip SystemBuilder::before and SystemBuilder::after docs #1377

merged 1 commit into from
Nov 22, 2024

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Nov 21, 2024 •
edited
Loading

Description

TL;DR the documentation was wrong, ty @SrGesus for the find

Checklist

  • Self-review changes.
  • Add entry to the changelog's unreleased section.

@RiscadoA RiscadoA added this to the 0.5 milestone Nov 21, 2024
@RiscadoA RiscadoA self-assigned this Nov 21, 2024
@RiscadoA RiscadoA requested a review from a team as a code owner November 21, 2024 15:48
@RiscadoA RiscadoA requested review from diogomsmiranda and RodrigoVintem and removed request for a team November 21, 2024 15:48
@RiscadoA RiscadoA linked an issue Nov 21, 2024 that may be closed by this pull request
Documentation on SystemBuilder::before and SystemBuilder::after is wrong #1371
Closed
@github-actions github-actions bot added the D-Trivial Can be done in 30 minutes label Nov 21, 2024
@RiscadoA RiscadoA requested a review from SrGesus November 21, 2024 15:48
@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1377/
on branch gh-pages at 2024-11-21 15:49 UTC

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.94%. Comparing base (b5a299b) to head (287fbc6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1377   +/-   ##
=======================================
  Coverage   41.94%   41.94%           
=======================================
  Files         441      441           
  Lines       33129    33129           
  Branches     3872     3872           
=======================================
  Hits        13895    13895           
  Misses      19234    19234

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

SrGesus
SrGesus approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@SrGesus SrGesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RiscadoA RiscadoA merged commit dcb021c into main Nov 22, 2024
11 checks passed
@RiscadoA RiscadoA deleted the 1371-documentation-on-systembuilderbefore-and-systembuilderafter-is-wrong branch November 22, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodrigoVintem RodrigoVintem RodrigoVintem approved these changes

@SrGesus SrGesus SrGesus approved these changes

@diogomsmiranda diogomsmiranda diogomsmiranda approved these changes

Assignees

@RiscadoA RiscadoA

Labels
A-Core B-ECS C-Documentation D-Trivial Can be done in 30 minutes
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

Documentation on SystemBuilder::before and SystemBuilder::after is wrong
4 participants
@RiscadoA @diogomsmiranda @SrGesus @RodrigoVintem