fix(memory): prevent double destruction in AnyVector::swapMove #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RiscadoA
requested review from
a team,
roby2014,
luishfonseca and
Dageus
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1358 +/- ##
=======================================
Coverage 41.95% 41.95%
=======================================
Files 441 441
Lines 33115 33115
Branches 3870 3870
=======================================
Hits 13893 13893
Misses 19222 19222 ☔ View full report in Codecov by Sentry. |
RiscadoA
requested review from
a team,
diogomsmiranda,
Dageus and
RodrigoVintem
and removed request for
Dageus,
roby2014,
luishfonseca and
a team
diogomsmiranda
approved these changes
Nov 8, 2024
|
Although one thing I notice now is why do we have assertions in the middle of srccode? Shouldn't we have tests with those instead? |
They're just sanity checks, it's good practice to write all assumptions of the code in assertions 😌 |
RodrigoVintem
approved these changes
Nov 8, 2024
Dageus
approved these changes
Nov 12, 2024
RiscadoA
force-pushed
the
ecs-double-free
branch
from
c2a7f10 to
719de61
Compare
This happened only when the last element of an AnyVector was removed in a swapMove. The destructor of the last element was called in the swapMove itself, and once again on pop.
RiscadoA
force-pushed
the
ecs-double-free
branch
from
719de61 to
05583bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This happened only when the last element of an AnyVector was removed in a swapMove.
The destructor of the last element was called in the swapMove itself, and once again on pop.
So, simply moved the extra destructor call to within the if itself.
Checklist