-O3 flag causes compiler error on ECS QueryFilter

[SrGesus]

Description

Added an assert that mNodeCount is smaller than the array size.
Had to also add some kind of "aliasing" to mNodeCount because the compiler thinks it might be mutated.

 138   │     int mNodeCount = this->mNodeCount;
 139   │     CUBOS_ASSERT(mNodeCount <= QueryNode::MaxCursorCount);
 140   │     for (int i = 1; i < mNodeCount; ++i)
 141   │     {
 142   │         mNodePins[i] = mNodePins[i - 1] | mNodes[i - 1]->pins();
 143   │     }

Context

• -O3 flag causes Compiler Error on ECS QueryFilter #1351

Checklist

• Self-review changes.
• Evaluate impact on the documentation.
• Ensure test coverage.
• Add entry to the changelog's unreleased section.

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1352/
on branch gh-pages at 2024-11-17 15:20 UTC

[RiscadoA]

Ty very much for chasing these bugs 🙏 LGTM other than the comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.95%. Comparing base (ddb18ac) to head (e582b02).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1352   +/-   ##
=======================================
  Coverage   41.95%   41.95%           
=======================================
  Files         441      441           
  Lines       33115    33117    +2     
  Branches     3870     3870           
=======================================
+ Hits        13893    13895    +2     
  Misses      19222    19222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[diogomsmiranda]

LGTM