Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unneeded index check in favor of just always splitting #210

Merged
merged 1 commit into from
Aug 25, 2023
Merged

refactor: remove unneeded index check in favor of just always splitting #210

merged 1 commit into from
Aug 25, 2023

Conversation

G-Rath
Copy link
Owner

@G-Rath G-Rath commented Aug 25, 2023

I realised first that strings.Contains could be used instead of strings.Index but then realised we can just always do the strings.Split (which'll later get replaced with a strings.Cut after go 1.19) 🤷

@G-Rath G-Rath merged commit 8c048cd into main Aug 25, 2023
8 checks passed
@G-Rath G-Rath deleted the refactor-pnpm branch August 25, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@G-Rath