refactor: remove unneeded index check in favor of just always splitti…

…ng (#210)
G-Rath · Aug 25, 2023 · 8c048cd · 8c048cd
1 parent 8a2a7bf
commit 8c048cd
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/pkg/lockfile/parse-pnpm-lock.go b/pkg/lockfile/parse-pnpm-lock.go
@@ -96,11 +96,9 @@ func extractPnpmPackageNameAndVersion(dependencyPath string) (string, string) {
 		return "", ""
 	}
 
-	underscoreIndex := strings.Index(version, "_")
-
-	if underscoreIndex != -1 {
-		version = strings.Split(version, "_")[0]
-	}
+	// peer dependencies in v5 lockfiles are attached to the end of the version
+	// with an "_", so we always want the first element if an "_" is present
+	version = strings.Split(version, "_")[0]
 
 	return name, version
 }