Skip to content

feat: add phpstan (#231)

Sign in for the full log view
GitHub Actions / Qodana for PHP completed Nov 11, 2023 in 0s

33 new problems found by Qodana for PHP

Qodana for PHP

33 new problems were found

Inspection name Severity Problems
Magic methods validity 🔴 Failure 1
Insecure 'uniqid(...)' usage (Insufficient Entropy Vulnerability) 🔴 Failure 1
Parameter type 🔶 Warning 6
Callable parameter usage violates definition 🔶 Warning 2
Binary-unsafe 'fopen(...)' usage 🔶 Warning 2
Null reference 🔶 Warning 2
Nested ternary operator 🔶 Warning 1
One-time use variables 🔶 Warning 1
Security advisories for Composer packages 🔶 Warning 1
Static methods invocation via '->' 🔶 Warning 1
Usage of internal entity ◽️ Notice 9
Static closure can be used ◽️ Notice 2
Unknown inspection suppression ◽️ Notice 2
::class can be used ◽️ Notice 1
Child method is exactly the same ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 145 in src/Components/Health/Checker/HealthChecker/PhpChecker.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Callable parameter usage violates definition

\[EA\] New value type (float) is not matching the resolved parameter type and might introduce types-related false-positives.

Check warning on line 90 in src/Components/Elasticsearch/ElasticsearchManager.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Callable parameter usage violates definition

\[EA\] New value type (null) is not matching the resolved parameter type and might introduce types-related false-positives.

Check notice on line 10 in src/Components/SystemConfig/ConfigSystemConfigLoader.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

::class can be used

\[EA\] Perhaps this can be replaced with \\Shopware\\Core\\System\\SystemConfig\\SystemConfigLoader::class.

Check warning on line 25 in src/Components/LineReader.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Binary-unsafe 'fopen(...)' usage

\[EA\] The mode is not binary-safe ('b' is missing, as documentation recommends).

Check warning on line 39 in src/Components/LineReader.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Binary-unsafe 'fopen(...)' usage

\[EA\] The mode is not binary-safe ('b' is missing, as documentation recommends).

Check failure on line 9 in src/Components/Elasticsearch/DisabledElasticsearchManager.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Magic methods validity

\[EA\] __construct is probably missing ElasticsearchManager::__construct call.

Check warning on line 42 in src/Command/EnvGetCommand.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Nested ternary operator

\[EA\] Nested ternary operator should not be used (maintainability issues).

Check failure on line 31 in src/Components/CacheHelper.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Insecure 'uniqid(...)' usage (Insufficient Entropy Vulnerability)

\[EA\] Please provide 'more_entropy' parameter in order to increase likelihood of uniqueness.

Check warning on line 31 in src/DependencyInjection/Configuration.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Null reference

\[EA\] Null pointer exception may occur here.

Check warning on line 25 in src/DependencyInjection/Configuration.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Null reference

\[EA\] Null pointer exception may occur here.

Check warning on line 40 in src/Components/CacheAdapter.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

One-time use variables

\[EA\] Variable $aPCUIterator is redundant.

Check notice on line 55 in src/Command/MonitorCommand.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Usage of internal entity

Method 'createDefaultContext' is marked as @internal

Check notice on line 251 in src/Controller/ShopwareFilesController.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Usage of internal entity

Method 'createDefaultContext' is marked as @internal

Check notice on line 26 in src/Components/Elasticsearch/ElasticsearchManager.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Usage of internal entity

Class 'CreateAliasTaskHandler' is marked as @internal

Check notice on line 13 in src/Components/Elasticsearch/ElasticsearchManager.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Usage of internal entity

Class 'ElasticsearchIndexer' is marked as @internal

Check notice on line 236 in src/Controller/ShopwareFilesController.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Usage of internal entity

Method 'createDefaultContext' is marked as @internal

Check notice on line 12 in src/Components/Elasticsearch/ElasticsearchManager.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Usage of internal entity

Class 'CreateAliasTaskHandler' is marked as @internal

Check notice on line 24 in src/Components/Elasticsearch/ElasticsearchManager.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Usage of internal entity

Class 'ElasticsearchIndexer' is marked as @internal

Check notice on line 145 in src/Command/MonitorCommand.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Usage of internal entity

Method 'createDefaultContext' is marked as @internal

Check notice on line 38 in src/Command/ChangeUserPasswordCommand.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Usage of internal entity

Method 'createDefaultContext' is marked as @internal

Check warning on line 64 in src/Components/CacheAdapter.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Parameter type

Parameter '$this-\>adapter' type is not compatible with declaration

Check warning on line 38 in src/Components/CacheAdapter.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Parameter type

Parameter '$this-\>adapter' type is not compatible with declaration

Check warning on line 34 in src/Components/CacheAdapter.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Parameter type

Parameter '$this-\>adapter' type is not compatible with declaration

Check warning on line 74 in src/Components/CacheAdapter.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Parameter type

Parameter '$this-\>adapter' type is not compatible with declaration

Check warning on line 60 in src/Components/CacheAdapter.php

See this annotation in the file changed.

@github-actions github-actions / Qodana for PHP

Parameter type

Parameter '$this-\>adapter' type is not compatible with declaration