Skip to content
Build extension

feat: add phpstan (#231) #262

Sign in to view logs

feat: add phpstan (#231)

feat: add phpstan (#231) #262

Triggered via push November 10, 2023 21:36
@shyimshyim
pushed 0aef4a9
main
Status Success
Total duration 19s
Artifacts 1

store.yml

on: push
build  /  Build
10s
build / Build
Fit to window
Zoom out
Zoom in

Annotations

2 errors, 16 warnings, and 15 notices
Magic methods validity: src/Components/Elasticsearch/DisabledElasticsearchManager.php#L9
\[EA\] __construct is probably missing ElasticsearchManager::__construct call.
Insecure 'uniqid(...)' usage (Insufficient Entropy Vulnerability): src/Components/CacheHelper.php#L31
\[EA\] Please provide 'more_entropy' parameter in order to increase likelihood of uniqueness.
Callable parameter usage violates definition: src/Components/Health/Checker/HealthChecker/PhpChecker.php#L145
\[EA\] New value type (float) is not matching the resolved parameter type and might introduce types-related false-positives.
Callable parameter usage violates definition: src/Components/Elasticsearch/ElasticsearchManager.php#L90
\[EA\] New value type (null) is not matching the resolved parameter type and might introduce types-related false-positives.
Binary-unsafe 'fopen(...)' usage: src/Components/LineReader.php#L25
\[EA\] The mode is not binary-safe ('b' is missing, as documentation recommends).
Binary-unsafe 'fopen(...)' usage: src/Components/LineReader.php#L39
\[EA\] The mode is not binary-safe ('b' is missing, as documentation recommends).
Nested ternary operator: src/Command/EnvGetCommand.php#L42
\[EA\] Nested ternary operator should not be used (maintainability issues).
Null reference: src/DependencyInjection/Configuration.php#L31
\[EA\] Null pointer exception may occur here.
Null reference: src/DependencyInjection/Configuration.php#L25
\[EA\] Null pointer exception may occur here.
One-time use variables: src/Components/CacheAdapter.php#L40
\[EA\] Variable $aPCUIterator is redundant.
Parameter type: src/Components/CacheAdapter.php#L64
Parameter '$this-\>adapter' type is not compatible with declaration
Parameter type: src/Components/CacheAdapter.php#L38
Parameter '$this-\>adapter' type is not compatible with declaration
Parameter type: src/Components/CacheAdapter.php#L34
Parameter '$this-\>adapter' type is not compatible with declaration
Parameter type: src/Components/CacheAdapter.php#L74
Parameter '$this-\>adapter' type is not compatible with declaration
Parameter type: src/Components/CacheAdapter.php#L60
Parameter '$this-\>adapter' type is not compatible with declaration
Parameter type: src/Controller/ScheduledTaskController.php#L66
Parameter '$handledMessages' type is not compatible with declaration
Security advisories for Composer packages: composer.json#L37
\[EA\] Please add roave/security-advisories:dev-latest into require-dev as a firewall for vulnerable components.
Static methods invocation via '->': src/Components/Health/Checker/HealthChecker/SystemInfoChecker.php#L39
\[EA\] '...::fromEnv(...)' should be used instead.
::class can be used: src/Components/SystemConfig/ConfigSystemConfigLoader.php#L10
\[EA\] Perhaps this can be replaced with \\Shopware\\Core\\System\\SystemConfig\\SystemConfigLoader::class.
Usage of internal entity: src/Command/MonitorCommand.php#L55
Method 'createDefaultContext' is marked as @internal
Usage of internal entity: src/Controller/ShopwareFilesController.php#L251
Method 'createDefaultContext' is marked as @internal
Usage of internal entity: src/Components/Elasticsearch/ElasticsearchManager.php#L26
Class 'CreateAliasTaskHandler' is marked as @internal
Usage of internal entity: src/Components/Elasticsearch/ElasticsearchManager.php#L13
Class 'ElasticsearchIndexer' is marked as @internal
Usage of internal entity: src/Controller/ShopwareFilesController.php#L236
Method 'createDefaultContext' is marked as @internal
Usage of internal entity: src/Components/Elasticsearch/ElasticsearchManager.php#L12
Class 'CreateAliasTaskHandler' is marked as @internal
Usage of internal entity: src/Components/Elasticsearch/ElasticsearchManager.php#L24
Class 'ElasticsearchIndexer' is marked as @internal
Usage of internal entity: src/Command/MonitorCommand.php#L145
Method 'createDefaultContext' is marked as @internal
Usage of internal entity: src/Command/ChangeUserPasswordCommand.php#L38
Method 'createDefaultContext' is marked as @internal
Child method is exactly the same: src/Components/Health/PerformanceCollection.php#L9
\[EA\] 'getExpectedClass' method can be dropped, as it identical to parent's one.
Static closure can be used: src/Controller/ShopwareFilesController.php#L72
\[EA\] This closure can be declared as static (better scoping; in some cases can improve performance).
Static closure can be used: src/Components/Health/Checker/HealthChecker/TaskChecker.php#L45
\[EA\] This closure can be declared as static (better scoping; in some cases can improve performance).
Unknown inspection suppression: src/Components/Health/Checker/HealthChecker/PhpChecker.php#L150
\[EA\] Unknown inspection: .
Unknown inspection suppression: src/Components/Health/Checker/HealthChecker/PhpChecker.php#L147
\[EA\] Unknown inspection: .

Artifacts

Produced during runtime
Name Size
FroshTools Expired
112 KB