Added more basic interfaces #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
interfaces
branch
3 times, most recently
from
11f2557
to
8784924
Compare
KuechA
reviewed
Jul 12, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/Interfaces.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/statements/expressions/CallExpression.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/ControlDependenceGraphPass.kt
Outdated
Show resolved
Hide resolved
oxisto
force-pushed
the
interfaces
branch
2 times, most recently
from
d13307c
to
3df6035
Compare
5 tasks
This PR adds more basic interfaces
|
KuechA
approved these changes
Jul 25, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/statements/expressions/CallExpression.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more basic interfaces. It solves the issue that we currently either have a direct node in our utility functions (for example symbol resolving), e.g. a
CallExpressionor some very specific interfacesHasBase. But as we for example need anamefor theHasBaseinterface/node, we need to do a very uglyas Nodecast.Therefore, in this PR we are adding some more basic interfaces that "describe" nodes, e.g., whether they have a name, location (actually all of the nodes have that) and a mixture of that.
This is prep work for #1606, for example where we need to share a common interface between calls and operator expressions which are overloadable. Something which is currently not yet possible with the current interfaces.