Added basic implementation of operator overloading #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
changed the title
oxisto
force-pushed
the
operator-resolution
branch
from
eecbd7b
to
3924bb5
Compare
This was referenced Jul 1, 2024
oxisto
force-pushed
the
operator-declaration
branch
3 times, most recently
from
f86c2ac
to
432105b
Compare
oxisto
force-pushed
the
operator-declaration
branch
2 times, most recently
from
a1badb9
to
9cd5df4
Compare
oxisto
force-pushed
the
operator-resolution
branch
5 times, most recently
from
a0c3a4e
to
4cc7f4a
Compare
oxisto
force-pushed
the
operator-resolution
branch
from
4cc7f4a
to
5ffe807
Compare
oxisto
force-pushed
the
operator-resolution
branch
from
5ffe807
to
f055ceb
Compare
oxisto
force-pushed
the
symbol-resolver-cleanup
branch
from
cdd2f29
to
16c584e
Compare
oxisto
force-pushed
the
operator-resolution
branch
from
f055ceb
to
494a5a9
Compare
oxisto
force-pushed
the
symbol-resolver-cleanup
branch
2 times, most recently
from
1cde93a
to
cea51b3
Compare
oxisto
force-pushed
the
operator-resolution
branch
from
494a5a9
to
da8ba63
Compare
oxisto
force-pushed
the
symbol-resolver-cleanup
branch
2 times, most recently
from
c3db66d
to
89ea939
Compare
oxisto
force-pushed
the
operator-resolution
branch
5 times, most recently
from
750138e
to
74d0c81
Compare
oxisto
force-pushed
the
operator-resolution
branch
4 times, most recently
from
01c17f6
to
7241b17
Compare
oxisto
added
enhancement
oxisto
changed the title
|
Since the frontend has to implement this feature, it would make sense to add this to the documentation page https://github.com/Fraunhofer-AISEC/cpg/blob/main/docs/docs/CPG/impl/language.md |
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/LanguageTraits.kt
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/ArgumentHolder.kt
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/StatementHolder.kt
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/edges/collections/EdgeList.kt
Show resolved
Hide resolved
...c/main/kotlin/de/fraunhofer/aisec/cpg/graph/statements/expressions/OperatorCallExpression.kt
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
oxisto
force-pushed
the
operator-resolution
branch
2 times, most recently
from
40b46d3
to
b4b8938
Compare
konradweiss
reviewed
Sep 12, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/LanguageTraits.kt
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Show resolved
Hide resolved
konradweiss
approved these changes
Sep 12, 2024
This PR makes sure that Python now properly uses our `TypeResolver` by only setting the unqualified name for a type and let the type resolver handle the rest. Otherwise we will get incorrect results, e.g., when retrieving name of a type within a class.
oxisto
force-pushed
the
operator-resolution
branch
from
b4b8938
to
f08b313
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic functionality for resolving operator overloading for languages that support it (via the trait
HasOperatorOverloading- which is currently python and C++). The respective frontend looks for function declarations that match entries inoverloadedOperatorNamesand creates anOperatorDeclaration.The
SymbolResolveris then looking for specific expressions (that implementHasOverloadedOperation) to see whether the expression is really an overloaded call to an operator declaration. In this case, the expression is replaced with anOperatorCallExpression, pointing to the respectiveOperatorDeclaration. This happens only if a declaration was found, currently, noOperatorDeclarationis inferred. This might be something for the future.Currently the following nodes support
HasOverloadedOperationand should work:BinaryOperator: Tested in C++ and PythonUnaryOperator: Tested in C++ and PythonMemberExpression: Only really possible in C++, also tested in C++. This is basically the main trick behind every smart pointer framework by overriding the->operator.CallExpression: Not testedThere are probably more expressions, such as array indices, etc. that currently do not implement
HasOverloadedOperationyet.This PR depends on the following PRs which need to be resolved first:
OperatorDeclaration#1605