Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try calculating code coverage normally (per-package) as it had been done before #1194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Try calculating code coverage normally (per-package) as it had been done before #1194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1528dce
Revert "Merge Makefile from inprogress branch to compute correct cove…
zenovich Jul 13, 2024
d6d04ac
Merge branch 'master' into try_calculating_code_coverage_normally
zenovich Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ PWD=$(shell pwd)
VERSION_FETCHING_CMD=git describe --always --dirty
GOBUILD_VERSION_INJECTION=-ldflags="-X main.version=$(shell $(VERSION_FETCHING_CMD))"

# Don't cover the packages ending by test, and separate the packages by a comma
COVER_PACKAGES=$(shell $(GOLIST) ./app/... | grep -v "test$$" | tr '\n' ',')

# Filter for tests
ifdef FILTER
TEST_FILTER=-run $(FILTER)
Expand Down Expand Up @@ -85,7 +82,7 @@ test: $(TEST_REPORT_DIR)
$(Q)# Warning: DIRECTORY must be a directory, it will fail if it is a file
$(Q)# add FILTER=functionToTest to only test a certain function. functionToTest is a Regex.

$(Q)$(GOTEST) -gcflags=all=-l -race -coverpkg=$(COVER_PACKAGES) -coverprofile=$(TEST_REPORT_DIR)/coverage.txt -covermode=atomic -v $(TEST_DIR) -p 1 -parallel 1 $(TEST_FILTER)
$(Q)$(GOTEST) -gcflags=all=-l -race -coverprofile=$(TEST_REPORT_DIR)/coverage.txt -covermode=atomic -v $(TEST_DIR) -p 1 -parallel 1 $(TEST_FILTER)
test-dev:
$(Q)$(GOTEST) -gcflags=all=-l $(TEST_DIR) -p 1 -parallel 1 $(TEST_FILTER)
test-unit:
Expand Down