Try calculating code coverage normally (per-package) as it had been done before #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rage" This reverts commit 5a48ff0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1194 +/- ##
===========================================
- Coverage 100.00% 96.54% -3.46%
===========================================
Files 237 236 -1
Lines 14675 14670 -5
===========================================
- Hits 14675 14163 -512
- Misses 0 502 +502
- Partials 0 5 +5 ☔ View full report in Codecov by Sentry. |
zenovich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the coverage of a package depends on tests in other packages which can lead to situations where modifying a test or code of one package leads to having to add tests in other packages. Also, computing the code coverage for the whole project as a monolith contradicts the idea of the packages as separate libraries.
Also, there is a technical decision made in March 2019 stating the code coverage should be computed per-package (https://github.com/France-ioi/algorea-devdoc/pull/60/files#diff-36f14a930e1574edebba78bb847f62fb08ae10745ffe74ae65deed384d213285R71).