merge n-ui-foundations into dotcom-ui-base-styles #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documented features
moved visualy hidden into mixin
Update README.md
Fix specificity accessibility issue
Remove old, unused links use-cases
…ment Add experimental BEM modifier for keyboard-focussed stuff
Update grid gutters - 20px on M, 30px on XL
Focus style (links)
outline fix
Make gutters smaller again
Delete .github/settings.yml
refactor: don't duplicate the o-normalise helpers
feat!: remove unused legacy n-ui-configured variable
only "used" in one place, which isn't actually using it
feat!: remove image mixin
i decided where it should live: nowhere there were only a handful of remaining uses, which will soon all be replaced with `o-spacing`
feat!: remove $spacing-unit
were previously used for CSS code splitting but are no longer in use at all https://github.com/search?q=org%3AFinancial-Times+nUiStylesheet+language%3ASCSS+-repo%3Afinancial-times%2Fdotcom-page-kit+-repo%3Afinancial-times%2Fn-ui+-repo%3Afinancial-times%2Fn-ui-foundations+-is%3Aarchived&type=code
…xins Remove code splitting mixins
.gitkeep the folder because it's used for the CSS output when testing
Deprecate javascript utils
apaleslimghost
force-pushed
the
ui-foundations-base-styles
branch
from
cbc8f96 to
8ab9e90
Compare
apaleslimghost
changed the title
ivomurrell
approved these changes
Jan 27, 2025
apaleslimghost
force-pushed
the
ui-foundations-base-styles
branch
from
8ab9e90 to
95d5232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR moves all the sass from n-ui-foundations into
dotcom-ui-base-styles. since this includes all the git history from n-ui-foundations, there's a lot of commits, and it's not going to be easily reviewable on its own. i'm going to do the actual work of integrating this sass intodotcom-ui-base-stylesin a separate PR based on this one, to make that easier to review.