integrate ex-n-ui-foundations styles into dotcom-ui-base-styles #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaleslimghost
force-pushed
the
base-styles-rethink
branch
from
d0020ad to
8d06271
Compare
it's supported in all the browsers we support https://caniuse.com/css-focus-visible
$n-ui-foundations-is-silent is unnecessary in a world where components aren't importing dotcom-ui-base-styles
apaleslimghost
force-pushed
the
base-styles-rethink
branch
from
dd64f97 to
72247ee
Compare
apaleslimghost
force-pushed
the
ui-foundations-base-styles
branch
from
cbc8f96 to
8ab9e90
Compare
apaleslimghost
requested a review
from ft-dependency-auto-merger
as a code owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates the n-ui-foundations styles included in #1062 to fit more into the Page Kit ecosystem, with an O3 future in mind. notably, this removes support for using
dotcom-ui-base-stylesin components, and recommends that components use Origami styles directly (there is no longer a need to have a default bundled set of styles for both components and apps, this is handled viapeerDependencies).this PR starts consuming
o3-foundationas a dependency, to replacenUiZIndexForwitho3-foundation's z-index variables. there's no way to import just the z-index variables, so this imports the whole ofo3-foundation. until we migratedotcom-ui-base-stylesfully to o3, this will increase the CSS bundle size. that's a tradeoff i'm willing to make for the next few months, to facilitate an easier migration path.