Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic every #75

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Fix dynamic every #75

merged 1 commit into from
Sep 4, 2023

Conversation

TrentHouliston
Copy link
Member

Dynamic every had a template mismatch that made doing on<Every<>>(std::chrono::seconds(1)) not work as the default template type in the using and the Every didn't match. This fixes the problem by making them match, and also by making it so the period does not matter.

Copy link
Contributor

@Bidski Bidski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrentHouliston TrentHouliston merged commit 9b705b1 into main Sep 4, 2023
11 checks passed
@TrentHouliston TrentHouliston deleted the houliston/every_fix branch September 4, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants